cargo_toml_env_vars: rule for generating env vars from a Cargo.toml file #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
cargo_toml_vars
branch
from
da86a97
to
2ec397a
Compare
This allows people to set all of the compile-time variables that would be set by Cargo. This doesn't currently wire up crate_universe to generate and depend on these targets for third-party crates, but I can add that if this PR looks good - it should just be a matter of a small addition to the generation templates (one new target, and setting `rustc_env_files` to point at the new target).
Cargo didn't set `CARGO_PKG_README` before then, and this avoids needing to make tests conditional on rust version.
illicitonion
force-pushed
the
cargo_toml_vars
branch
from
2ec397a
to
8744879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to set all of the compile-time variables that would be set by Cargo.
This doesn't currently wire up crate_universe to generate and depend on these targets for third-party crates, but I can add that if this PR looks good - it should just be a matter of a small addition to the generation templates (one new target, and setting
rustc_env_filesto point at the new target).Work towards #2677