Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] only generate rust libraries with coverage instrumentation only when coverage is enabled #2858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ryang20718
Copy link

Currently, binaries produced by rust_binary generate profraw files which means the binary is built with code coverage instrumentation with bazel build. We should only generate coverage with bazel coverage. This PR fixes this bug

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is this something you can add an analysis test for? Maybe add a coverage directory to https://github.com/bazelbuild/rules_rust/tree/0.50.0/test/unit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants