Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track callsites of where observers are initially triggered. #14708

Open
ItsDoot opened this issue Aug 11, 2024 · 1 comment · May be fixed by #15607
Open

Track callsites of where observers are initially triggered. #14708

ItsDoot opened this issue Aug 11, 2024 · 1 comment · May be fixed by #15607
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@ItsDoot
Copy link
Contributor

ItsDoot commented Aug 11, 2024

What problem does this solve or what need does it fill?

Similar idea to #14034. Via a feature flag, we should be able to track where observers are getting triggered from.

What solution would you like?

Storing the callsite location as part of the Trigger, so that it's accessible inside the triggered observer.
@ItsDoot ItsDoot added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events labels Aug 11, 2024
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed C-Feature A new feature, making something new possible labels Aug 11, 2024
@alice-i-cecile
Copy link
Member

We should probably do the same thing with hooks too.

@alice-i-cecile alice-i-cecile added the D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes label Aug 11, 2024
@SpecificProtagonist SpecificProtagonist linked a pull request Oct 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track callsite for observers & hooks SpecificProtagonist/bevy
2 participants
@alice-i-cecile @ItsDoot