fix: x,y in rect changed when sprite scale to a minimum size #289
+127
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14e2aed The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@caohongz 太棒了 最好能补充单测， |
hughfenghen
reviewed
Sep 30, 2024
| * 值为 true 时，将固定中心点不变进行缩放 | ||
| * 值为 false 时，将固定对角点不变进行缩放 | ||
| */ | ||
| scaleFixedCenter = false; |
There was a problem hiding this comment.
建议修改命名 fixedScaleCenter， 跟 fixedAspectRatio 保持相似模式
1、有一些关联，我会尽量拆分成两个PR，如果拆分不开我会新开一个Feature的，附带修复bug； |
本次PR仅修复缩放bug，添加了带旋转角度的单测，后续另开PR添加新功能。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复：针对sprite缩放时，如缩放后的尺寸小于最小限制，会出现x和y坐标点漂移的问题。
最终效果如下：
fixed3.mp4