Refactor/parse mp4 #291
Open
Refactor/parse mp4 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef8605b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 7, 2024
Closed
wendraw
reviewed
Oct 8, 2024
| if (box == null) break; | ||
|
|
||
| if (box.name === 'moof') isFMP4 = true; | ||
| if (box.name === 'mdat' && box.data == null) { |
There was a problem hiding this comment.
看了一下 getNextBox 返回的 mdat 类型 box 就是把 data 去掉的，那么下面的 if (box.data != null) 分支是不是永远不会执行？或者说 mp4boxFile 会重复解析？
| let remainSize = box.size; | ||
| while (remainSize > 0) { | ||
| // 非 fMP4 文件的 mdat box 非常大，一次最多读取 30MB，避免内存占用过大 | ||
| const chunkSize = Math.min(remainSize, 30 * 1024 * 1024); |
There was a problem hiding this comment.
这个 30MB 是 hard code，为什么不是 10M/20M？或许这个值可以开放给使用者控制？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重构：基于文件读写的方式解析 mp4，替代以前基于流（ReadableStream）解析。
解决大体积 mp4 文件在解析阶段内存占用过大的问题。
Closes #129