Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for special functions of tensors added #170

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Neel-Shah-29
Copy link
Contributor

I have added the documentation of special functions for tensors as instructed in proposal #167 (comment)

@amitsingh19975
Copy link
Collaborator

amitsingh19975 commented Feb 24, 2022

You just added the file special_functions.adoc, but there is no link to the file. Please, add the link in the index to access it. Otherwise, users will not know about it. It's like you created a function, and you never used it.

Furthermore, I would expect you to take some time and define each function properly without using a table. Each function to have its own section, where you define it, give the prototype, and examples using code blocks. Keep in mind to provide tensor specific behaviour, such as if a method is valid for static tensor or not, is there a tensor type-specific behaviour, etc.

Also, think about readability than concise or cryptic documentation. Put yourself in the shoes of a newbie, who doesn't know about the library that well, and how will (s)he react to the documentation, will it help them to understand it.

@Neel-Shah-29
Copy link
Contributor Author

Hello, So for the first requirement i need to add the link of the files where all the special functions are used right?
Also i will be giving explaination prototype and examples of each function using code blocks in some time, thanks for the suggestion.

@amitsingh19975
Copy link
Collaborator

Hello, So for the first requirement i need to add the link of the files where all the special functions are used right?

Read the existing document to see how to link the file or take help from @shikharvashistha.

@amitsingh19975
Copy link
Collaborator

I'm sharing a screenshot of what I meant. Don't let your ideas be clouded by what I'm sharing, and add something you think would be much better than what I'm suggesting. My top priority for documentation is "readability" and "the user does not have to read the codebase to figure out how's the library works."

Screenshot 2022-02-25 at 5 17 43 PM

@Neel-Shah-29
Copy link
Contributor Author

Neel-Shah-29 commented Mar 4, 2022

Hello I have prepared the documentation for the special functions, I just wanted to ask that the code examples that needs to be added for each function should be taken from the codebase only right ? i.e from functions.hpp where they are implemented

@amitsingh19975
Copy link
Collaborator

Hello I have prepared the documentation for the special functions, I just wanted to ask that the code examples that needs to be added for each function should be taken from the codebase only right ? i.e from functions.hpp where they are implemented

Yes, you can also refer to the examples folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants