Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore credential_process when set to the empty string #3099

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rdctmeconomou
Copy link

@rdctmeconomou rdctmeconomou commented Jan 13, 2024

This implements the fix to botocore.credentials.ProcessProvider.load() described in #3098. I added a test that reproduced the bug. The test passes with my fix applied.

Please note that linting fails in test code released as part of botocore 1.34.18. I didn't think it wise to modify anything outside the scope of my bug report but am happy to commit a style fix if necessary.

@rdctmeconomou
Copy link
Author

rdctmeconomou commented Jan 15, 2024

I noticed #3100 and will rebase my PR as soon as that's merged.
This is done.

@rdctmeconomou rdctmeconomou force-pushed the empty-credential-process branch 3 times, most recently from ead7387 to da4aa9b Compare January 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant