-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async fetch configuration #1399
Draft
KunJeongPark
wants to merge
37
commits into
main
Choose a base branch
from
async-fetchConfiguration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 542bf33.
# Conflicts: # Sources/BraintreeCard/BTCardClient.swift
# Conflicts: # Sources/BraintreePayPal/BTPayPalClient.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Replacing of completion handler version of
fetchOrReturnRemoteConfiguration
required wrapping the functions in Task blocks within functions that return results via completion handler to the merchants.There were many changes to unit tests required as tests with mocks returned results synchronously and asynchronous nature of the Task blocks required slight delays for the assertions.
I think there are a lot of considerations -
Consider refactoring functions wrapped with withCheckedContinuation to true asynchronous/await syntax where possible
How far down do we refactor? Within the task blocks, there are many subsequent function calls that pass down the completion handlers. I am unsure about top down approach to the refactor where we have task block for top level tokenize function for instance, as opposed to bottom up, like the apiClient’s post function or the functions that tokenize calls.
We should do careful and extensive testing to make sure that there are no unintended consequences especially in app switching context. Major difference with creating a Task block is that it does not inherit the context of its caller by default. We should test thoroughly to ensure that there are no subtle bugs introduced like deadlocks and priority inversions.
I will open another ticket to continue to test and improve on the refactor started here.
Checklist
Authors