Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support standard environment variables #509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PSanetra
Copy link

@PSanetra PSanetra commented Oct 9, 2024

Closes #81

Changes

  • Make previously required parameters of oauth_channel.create_oauth2_client_credentials_channel() and oauth_channel.create_camunda_cloud_channel() optional

API Updates

New Features (required)

oauth_channel.create_oauth2_client_credentials_channel() and oauth_channel.create_camunda_cloud_channel() support the following environment variables:

  • ZEEBE_ADDRESS
  • CAMUNDA_CLUSTER_ID
  • CAMUNDA_CLUSTER_REGION
  • CAMUNDA_CLIENT_ID
  • ZEEBE_CLIENT_ID
  • CAMUNDA_CLIENT_SECRET
  • ZEEBE_CLIENT_SECRET
  • CAMUNDA_OAUTH_URL
  • ZEEBE_AUTHORIZATION_SERVER_URL
  • CAMUNDA_CREDENTIALS_SCOPES
  • CAMUNDA_TOKEN_AUDIENCE
  • ZEEBE_TOKEN_AUDIENCE

Checklist

  • Unit tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11257124077

Details

  • 45 of 47 (95.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 96.813%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyzeebe/channel/oauth_channel.py 9 11 81.82%
Totals Coverage Status
Change from base Build 11248787810: -0.07%
Covered Lines: 1124
Relevant Lines: 1161

💛 - Coveralls

@PSanetra PSanetra force-pushed the add-environment-variables branch 2 times, most recently from 58ae243 to d2d7ac9 Compare October 9, 2024 14:21
@felicijus
Copy link
Contributor

felicijus commented Oct 9, 2024

@dimastbk I would like to check the Camunda Cloud implementation side of this again, review should be in tomorrow.

@PSanetra thank you, you were quicker I also had this planned as a prull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use environment variables to configure Zeebe
4 participants