Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init #1

Merged
merged 54 commits into from
May 22, 2024
Merged

feat: init #1

merged 54 commits into from
May 22, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented May 15, 2024 •
edited
Loading

This pull request addresses the implementation of the project outlined in https://github.com/camunda/team-infrastructure-experience/issues/237.

Since the project was recently created, I kindly ask for a comprehensive review of the entire project.

Details:

  • Successful GitHub Actions Run: Link

Thank you in advance for the time you will take to review this pull request :)

@leiicamundi
fix pass
7c20058
@leiicamundi
improve tests
acd3892
@leiicamundi
debug without delete
36224c2
@leiicamundi
reuse same name
715a228
@leiicamundi
add readme
706296d
@leiicamundi
launch other instance
9c6c590
@leiicamundi
conditional cluster definition
4a0c8b5 
ocp_cluster_name=leogit

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
150ec70 
ocp_cluster_name=leogit

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
8f646c8 
ocp_cluster_name=leogit2

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
addc3c2 
ocp_cluster_name=leogit

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
02b6fc8 
ocp_cluster_name=leogit3

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
793b692 
ocp_cluster_name=leogit2

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
5723ede 
ocp_cluster_name=leogit4

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
972d4fd 
ocp_cluster_name=leogit4

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
f261d20 
ocp_cluster_name=leogit3

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
22ada8f 
ocp_cluster_name=leogit4

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
dc42996 
ocp_cluster_name=leogit5

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
d13bd45 
ocp_cluster_name=leogit5

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
9cdbd1d 
ocp_cluster_name=leogit6

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
aeb7745 
ocp_cluster_name=leogit5

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
6954e59 
ocp_cluster_name=leogit7

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
43d9f2c 
ocp_cluster_name=leogit7

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
8c63f6a 
ocp_cluster_name=leogit7

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
0e31d47 
ocp_cluster_name=leogit7

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
9ff1ad4 
ocp_cluster_name=leogit8

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
7394ea9 
ocp_cluster_name=leogit7

delete_ocp_cluster=true
@leiicamundi
conditional cluster definition
f9ccada 
ocp_cluster_name=leogit8

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
34ea308 
ocp_cluster_name=leogit8

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
a4ef989 
ocp_cluster_name=leogit9

delete_ocp_cluster=false
@leiicamundi
conditional cluster definition
70b37a1 
ocp_cluster_name=leogit8

delete_ocp_cluster=true
Langleu
Langleu reviewed May 17, 2024
View reviewed changes
DEVELOPER.md Outdated Show resolved Hide resolved
Langleu
Langleu reviewed May 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
Langleu
Langleu reviewed May 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
Langleu
Langleu requested changes May 17, 2024
View reviewed changes
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try it out but had a look at the github actions runs, which are using it successfully and looks really good so far!

Mostly just consistency / styling matters from my side.

@leiicamundi
Copy link
Contributor Author

I didn't try it out but had a look at the github actions runs, which are using it successfully and looks really good so far!

Mostly just consistency / styling matters from my side.

Thanks for the review @Langleu! I made the requested adjustments, let me know if it works for you

@leiicamundi leiicamundi requested a review from Langleu May 21, 2024 07:02
Langleu
Langleu requested changes May 22, 2024
View reviewed changes
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small aws cli version adjustments.
And a small question for me to understand whether the multi apply would work.
Besides that, great work 🚀

@leiicamundi leiicamundi merged commit 5f9e482 into main May 22, 2024
2 checks passed
@leiicamundi leiicamundi deleted the feature/init-action branch May 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Langleu Langleu Langleu approved these changes

Assignees

@leiicamundi leiicamundi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leiicamundi @Langleu