-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bitshuffle lz4 decompression for DLS Eiger images. #236
base: main
Are you sure you want to change the base?
Conversation
So I have removed the bitshuffle files and added the package to the ci-conda-env. |
as an aside: the bitshuffle package is not currently built on Windows -> conda-forge/bitshuffle-feedstock#18 |
We should probably subclass the Format...DLS.py to include an Or some equivalent for the locally compiled code. But it would mean we have a nice fallback. |
further: will need to add bitshuffle dependency to the cctbx bootstrap etc. Also: wasn't |
|
@jbeilstenedmands trying to build now to see how this works out |
Is this still relevant? At least the format class |
This PR is probably obsolete, but the philosophy behind it is probably valid. |
Implements a faster Eiger decompression using bshuf_decompress_lz4 from bitshuffle. The changes are restricted to only affect
FormatNexusEigerDLS.py
as I believe we can only make certain assumptions about the data structure for DLS written data.Outstanding issues:
build/lib/dxtbx_format_nexus_ext.so: undefined symbol: H5DOread_chunk
. I'm hoping someone has suggestions on the fix for this?Testing on my local machine, this reduced the runtime by ~25% for each call to
imageset.get_raw_data(i)
, I would like to test on the DLS systems also.