Skip to content

Commit

Permalink
Save xmm7 in DyadicBilinearQuarterDownsampler_sse
Browse files Browse the repository at this point in the history
Static analysis of chrome.dll showed that xmm7 was being used but not
preserved in this function. The Windows calling convention requires
that xmm7 be preserved so this change adds the necessary "PUSH_XMM 8"
and POP_XMM directives to fix this.

This fixes issue #3585. This may fix a bug in Chrome but that is
unknown.
  • Loading branch information
randomascii authored and Yuhengwe1 committed Feb 20, 2023
1 parent 7fa9e03 commit 24a19f8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions codec/processing/src/x86/downsample_bilinear.asm
Original file line number Diff line number Diff line change
Expand Up @@ -1948,6 +1948,7 @@ WELS_EXTERN DyadicBilinearQuarterDownsampler_sse
%assign push_num 0
%endif
LOAD_6_PARA
PUSH_XMM 8
SIGN_EXTENSION r1, r1d
SIGN_EXTENSION r3, r3d
SIGN_EXTENSION r4, r4d
Expand Down Expand Up @@ -2087,6 +2088,7 @@ WELS_EXTERN DyadicBilinearQuarterDownsampler_sse
%ifndef X86_32
pop r12
%endif
POP_XMM
LOAD_6_PARA_POP
%ifdef X86_32
pop r6
Expand Down

0 comments on commit 24a19f8

Please sign in to comment.