-
Notifications
You must be signed in to change notification settings - Fork 357
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent race conditions when cancelling service binding creations
The CreateBindingAsyncJob processes service credential bindings, service keys and service route bindings. There can be race conditions when a delete has been successful just before the polling times out or the entire job expires. Add tests to the 'create binding job' shared examples to simulate the scenarios outlined above. The resource being gone results in a Sequel::NoExistingObject exception that is now caught and logged. Furthermore the database resource is only loaded once per job execution (resulting in less database queries) and reloaded when needed.
- Loading branch information
1 parent
5598462
commit 3c98a32
Showing
2 changed files
with
67 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters