Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor permisions can_read_route? #3929

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor permisions can_read_route? #3929

wants to merge 1 commit into from

Conversation

Gerg
Copy link
Member

@Gerg Gerg commented Aug 13, 2024

  • Use role_applies? with the existing roles constant, rather than querying the user's org and space membership
  • Remove duplicate tests

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- Use role_applies? with the existing roles constant, rather than
  querying the user's org and space membership
- Remove duplicate tests
@Gerg Gerg requested a review from tcdowney August 13, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant