Skip to content

Commit

Permalink
Allow specifying pof-maven-plugin version (#126)
Browse files Browse the repository at this point in the history
* All specifying pof-maven-plugin version
* Specify pof-maven-plugin version for snapshots
  • Loading branch information
tmiddlet2666 authored Aug 22, 2024
1 parent eb472aa commit 87ef76f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven-build-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
shell: bash
run: |
echo "Running verify against $COH_VERSION"
mvn --file pom.xml -nsu --batch-mode -e -Dcoherence.version=$COH_VERSION clean install
mvn --file pom.xml -nsu --batch-mode -e -Dcoherence.version=$COH_VERSION -Dpof.maven.plugin.version=24.03.1 clean install
echo "==== Testing end-points ====="
mvn exec:exec > server.log 2>&1 &
PID=$!
Expand Down
7 changes: 5 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@
<netty.version>4.1.110.Final</netty.version>
<opentracing.jdbc.version>0.2.15</opentracing.jdbc.version>

<pof.maven.plugin.version>${coherence.version}</pof.maven.plugin.version>
<pof.maven.plugin.group>${coherence.group.id}</pof.maven.plugin.group>

<!-- maven configuration -->
<java.version>21</java.version>
<maven.assembly.plugin.version>3.0.0</maven.assembly.plugin.version>
Expand Down Expand Up @@ -392,9 +395,9 @@
</plugin>

<plugin>
<groupId>com.oracle.coherence.ce</groupId>
<groupId>${pof.maven.plugin.group}</groupId>
<artifactId>pof-maven-plugin</artifactId>
<version>24.03.1</version>
<version>${pof.maven.plugin.version}</version>
<executions>
<execution>
<id>instrument</id>
Expand Down

0 comments on commit 87ef76f

Please sign in to comment.