Minor code updates (#117)

* Minor code updates * Sonarcloud
coherence-community · Jul 16, 2024 · ebaf5cf · ebaf5cf
1 parent 36b0758
commit ebaf5cf
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/pom.xml b/pom.xml
@@ -31,14 +31,14 @@
     <coherence.group.id>com.oracle.coherence.ce</coherence.group.id>
 
     <!-- dependency versions -->
-    <bedrock.version>7.0.3</bedrock.version>
+    <bedrock.version>7.0.4</bedrock.version>
     <coherence.version>24.03</coherence.version>
     <jakarta.xml.bind.version>3.0.1</jakarta.xml.bind.version>
     <copy.rename.maven.plugin.version>1.0.1</copy.rename.maven.plugin.version>
     <derby.version>10.17.1.0</derby.version>
     <docker.version>${project.version}</docker.version>
     <eclipselink.version>4.0.2</eclipselink.version>
-    <jackson.version>2.17.1</jackson.version>
+    <jackson.version>2.17.2</jackson.version>
     <jackson.databind.version>${jackson.version}</jackson.databind.version>
     <jaeger.version>1.8.1</jaeger.version>
     <jaxrs.version>3.0.0</jaxrs.version>
@@ -62,7 +62,7 @@
     <maven.enforcer.plugin.version>3.5.0</maven.enforcer.plugin.version>
     <maven.exec.plugin.version>3.3.0</maven.exec.plugin.version>
     <maven.jandex.plugin.version>1.2.3</maven.jandex.plugin.version>
-    <maven.javadoc.plugin.version>3.6.3</maven.javadoc.plugin.version>
+    <maven.javadoc.plugin.version>3.7.0</maven.javadoc.plugin.version>
     <maven.resources.plugin.version>3.1.0</maven.resources.plugin.version>
     <maven.replacer.plugin.version>1.5.3</maven.replacer.plugin.version>
     <maven.source.plugin.version>3.3.1</maven.source.plugin.version>

diff --git a/src/main/java/com/oracle/coherence/demo/application/PersistenceHelper.java b/src/main/java/com/oracle/coherence/demo/application/PersistenceHelper.java
@@ -1,7 +1,7 @@
 /*
  * File: PersistenceHelper.java
  *
- * Copyright (c) 2015, 2020 Oracle and/or its affiliates.
+ * Copyright (c) 2015, 2024 Oracle and/or its affiliates.
  *
  * You may not use this file except in compliance with the Universal Permissive
  * License (UPL), Version 1.0 (the "License.")
@@ -118,7 +118,7 @@ public PersistenceHelper() {
             waitForRegistration(registry, Registry.CLUSTER_TYPE);
         }
         catch (InterruptedException e) {
-            throw Base.ensureRuntimeException(e, "Unable to find MBean");
+            throw new IllegalStateException("Unable to find MBean: " + e.getMessage());
         }
     }
 

diff --git a/src/main/java/com/oracle/coherence/demo/application/TracingFilter.java b/src/main/java/com/oracle/coherence/demo/application/TracingFilter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020 Oracle and/or its affiliates.
+ * Copyright (c) 2020, 2024 Oracle and/or its affiliates.
  *
  * You may not use this file except in compliance with the Universal Permissive
  * License (UPL), Version 1.0 (the "License.")
@@ -26,7 +26,7 @@
 
 import java.net.URI;
 
-import java.util.HashMap;
+import java.util.Map;
 
 import jakarta.ws.rs.container.ContainerRequestContext;
 import jakarta.ws.rs.container.ContainerRequestFilter;
@@ -89,9 +89,7 @@ public void filter(ContainerRequestContext requestContext,
         if (responseContext.getStatusInfo().getFamily()
             == Response.Status.Family.SERVER_ERROR) {
             Tags.ERROR.set(span, true);
-            span.log(new HashMap<String, String>() {{
-                put("event", "error");
-            }});
+            span.log(Map.of("event", "error"));
         }
 
         Tags.HTTP_STATUS.set(span, responseContext.getStatus());

diff --git a/src/main/resources/web/index.html b/src/main/resources/web/index.html
@@ -461,7 +461,7 @@ <h2 class="page-header"><img src="images/coherence.png" class="pull-left" style=
 
         <hr>
         <div class="col-lg-12">
-            <p>© 2020 Oracle Corporation. All Rights Reserved.
+            <p>© 2024 Oracle Corporation. All Rights Reserved.
             <img class="pull-right" src="images/oracle.png">
         </div>
 

diff --git a/src/main/resources/web/javascripts/controllers.js b/src/main/resources/web/javascripts/controllers.js
@@ -262,7 +262,7 @@ demoApp.controller('DemoController', ['$scope', '$http', '$interval', '$location
             let chartData = response.data;
 
             let tradeSummary = chartData.tradeSummary;
-            self.symbolNames = Object.keys(tradeSummary).sort();
+            self.symbolNames = Object.keys(tradeSummary).sort((i1, i2) => i1[1].localeCompare(i2[1]));
             self.symbolsChartData = [];
             self.symbolQuantity = {};
             self.symbolCount = {};