Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement ticker prefixes using key: Seq[String] concatenation #3697

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 9, 2024

This re-implements the ticker log prefixes that were left out in #3577, both for meta-build prefixes and nested-evaluation prefixes, e.g. the log prefix now looks like [build.mill-1] [mill-build/build.mill-1] etc.

  • We no longer need dynamicTickerPrefix, because we now perform this context management by wrapping nested PrefixLoggers

  • Required some gross mangling to consolidate Logger and ColorLogger interfaces in order to make things properly stackable

  • We needed to move the aggregation of keys to a top-down process, rather than bottom up, since it is not easy to take an already prefixed line [1] my logs line and append to the prefix [1-2] my logs line. Thus we need to make sure the log line is properly prefixed at the bottom-most logger, and the log line is passed up via unprefixedSystemStreams to avoid redundant prefixing

Screenshot 2024-10-09 at 7 36 05 PM

@lihaoyi lihaoyi marked this pull request as ready for review October 9, 2024 15:55
@lihaoyi lihaoyi merged commit 3d0bb6e into com-lihaoyi:main Oct 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant