Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibmse: SE_SKIP_CERTS_VERIFICATION for all KBS image #460

Merged
merged 1 commit into from
Aug 10, 2024
Merged

ibmse: SE_SKIP_CERTS_VERIFICATION for all KBS image #460

merged 1 commit into from
Aug 10, 2024

Conversation

huoqifeng
Copy link

@huoqifeng huoqifeng commented Aug 9, 2024 •
edited
Loading

Enable release image to have SE_SKIP_CERTS_VERIFICATION also

Signed-off-by: Qi Feng Huo [email protected]

ibmse: SKIP_CERTS_VERIFICATION for all image
36e355f 
Enable release image to have SE_SKIP_CERTS_VERIFICATION also

Signed-off-by: Qi Feng Huo <[email protected]>
@huoqifeng huoqifeng requested a review from sameo as a code owner August 9, 2024 01:57
@huoqifeng
Copy link
Author

@liudalibj @BbolroC , I'd like to enable SE_SKIP_CERTS_VERIFICATION for kbs images include release. wdyt?

@liudalibj
Copy link
Member

@liudalibj @BbolroC , I'd like to enable SE_SKIP_CERTS_VERIFICATION for kbs images include release. wdyt?

It will be GREAT helpful, if we can include the SE_SKIP_CERTS_VERIFICATION in release build, we can use the upstream kbs build directly when we work with a development LPAR.

liudalibj
liudalibj approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fitzthum
fitzthum approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increases the likelihood of someone accidentally not verifying the cert, but I am ok with it.

@Xynnn007 Xynnn007 merged commit e30d42e into confidential-containers:main Aug 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@fitzthum fitzthum fitzthum approved these changes

@liudalibj liudalibj liudalibj approved these changes

@sameo sameo Awaiting requested review from sameo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huoqifeng @liudalibj @mkulke @fitzthum @Xynnn007