Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ita: updated trusted_certs_paths property documentation #515

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pawelpros
Copy link
Contributor

No description provided.

@pawelpros pawelpros requested a review from a team as a code owner September 27, 2024 10:43
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Also would be good to add a slightly longer commit message even though the PR is very simple.

kbs/docs/config.md Outdated Show resolved Hide resolved
Updated Attestation Token Configuration section in documentation which describes supported trusted_certs_paths values:

- Local PEM file
- Valid URL (local and remote) pointing to JWKSet

Signed-off-by: Pawel Proskurnicki <[email protected]>
@pawelpros
Copy link
Contributor Author

Commit message updated and comment solved

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit 7df333d into confidential-containers:main Sep 30, 2024
14 checks passed
@mythi
Copy link
Contributor

mythi commented Oct 1, 2024

apologies, I did not do any reviews because of #514. It might take some time to get those changes in so getting this merged makes sense.

What's missing is that for "Valid values" we also have Jwk.

@pawelpros pawelpros deleted the itadocs branch October 2, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants