Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ita: add USER_AGENT to HTTP header #520

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Oct 1, 2024

No description provided.

@mythi mythi requested a review from a team as a code owner October 1, 2024 07:19
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add commit message. Otherwise seems good.

@pawelpros
Copy link
Contributor

PR tested on Azure environment - works fine

USER_AGENT missing was noticed being missing in a review. Add an identity
for "Coco trustee kbs" originated requests.

Signed-off-by: Mikko Ylinen <[email protected]>
Jwk was recently added as a new Attestation Token Verifier
type. Update attestation_token_config documentation accordingly.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
Copy link
Contributor Author

mythi commented Oct 2, 2024

commit message added. I also made one addition to attestation_token_config (Jwk type was missing)

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit c9dbfe0 into confidential-containers:main Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants