Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret to login #858

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add secret to login #858

merged 1 commit into from
Oct 7, 2024

Conversation

mhjacks
Copy link
Contributor

@mhjacks mhjacks commented Oct 4, 2024

Add option to podman_login module to use secret on podman >= 4.7.0

@mhjacks mhjacks mentioned this pull request Oct 4, 2024
Closed
sshnaidm
sshnaidm reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments added to the code.

changelogs/add_secret_to_login.yml Outdated Show resolved Hide resolved
tests/integration/targets/podman_login/tasks/main.yml Show resolved Hide resolved
tests/integration/targets/podman_login/tasks/main.yml Show resolved Hide resolved
plugins/modules/podman_login.py Outdated Show resolved Hide resolved
plugins/modules/podman_login.py Outdated Show resolved Hide resolved
tests/integration/targets/podman_login/tasks/main.yml Show resolved Hide resolved
@sshnaidm
Copy link
Member

sshnaidm commented Oct 6, 2024

Please sign the commit with -s, it's requirement for containers org.

@mhjacks mhjacks force-pushed the add_secret_to_login branch 3 times, most recently from e18c7f0 to dae4fa3 Compare October 7, 2024 00:12
@mhjacks mhjacks requested a review from sshnaidm October 7, 2024 00:13
@mhjacks mhjacks force-pushed the add_secret_to_login branch 3 times, most recently from e62fbf2 to cb4cd10 Compare October 7, 2024 01:17
@sshnaidm
Copy link
Member

sshnaidm commented Oct 7, 2024

Just last nit and should be fine:

ERROR: Found 1 yamllint issue(s) which need to be resolved:
ERROR: tests/integration/targets/podman_login/tasks/main.yml:137:1: empty-lines: too many blank lines (1 > 0)
FATAL: The 1 sanity test(s) listed below (out of 24) failed. See error output above for details.

@mhjacks @sshnaidm
Add secret to login module
bfe2e80 
Signed-off-by: Martin Jackson <[email protected]>
Co-authored-by: Sergey <[email protected]>
@mhjacks
Copy link
Contributor Author

mhjacks commented Oct 7, 2024

The yamllint issue should be fixed now. Thanks!

@sshnaidm
Copy link
Member

sshnaidm commented Oct 7, 2024

Great, thanks for contribution!

@sshnaidm sshnaidm merged commit e46c7eb into containers:master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshnaidm sshnaidm sshnaidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhjacks @sshnaidm