[v5.2-rhel] Fix podman stop and podman run --rmi
#24197
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Could you add a reference to the commit that this is a backport of 458ba5a? Have you used |
|
I did do a |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/clean_9.5_0day
branch
from
f747586
to
c0a1fc0
Compare
This started off as an attempt to make `podman stop` on a container started with `--rm` actually remove the container, instead of just cleaning it up and waiting for the cleanup process to finish the removal. In the process, I realized that `podman run --rmi` was rather broken. It was only done as part of the Podman CLI, not the cleanup process (meaning it only worked with attached containers) and the way it was wired meant that I was fairly confident that it wouldn't work if I did a `podman stop` on an attached container run with `--rmi`. I rewired it to use the same mechanism that `podman run --rm` uses, so it should be a lot more durable now, and I also wired it into `podman inspect` so you can tell that a container will remove its image. Tests have been added for the changes to `podman run --rmi`. No tests for `stop` on a `run --rm` container as that would be racy. Fixes containers#22852 Fixes RHEL-39513 For this branch Backport of: [458ba5a](containers@458ba5a) Fixes: https://issues.redhat.com/browse/RHEL-61667 Signed-off-by: Matt Heon <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/clean_9.5_0day
branch
from
c0a1fc0
to
a5766aa
Compare
This started off as an attempt to make
podman stopon a container started with--rmactually remove the container, instead of just cleaning it up and waiting for the cleanup process to finish the removal.In the process, I realized that
podman run --rmiwas rather broken. It was only done as part of the Podman CLI, not the cleanup process (meaning it only worked with attached containers) and the way it was wired meant that I was fairly confident that it wouldn't work if I did apodman stopon an attached container run with--rmi. I rewired it to use the same mechanism thatpodman run --rmuses, so it should be a lot more durable now, and I also wired it intopodman inspectso you can tell that a container will remove its image.Tests have been added for the changes to
podman run --rmi. No tests forstopon arun --rmcontainer as that would be racy.Fixes #22852
Fixes RHEL-39513
For this branch
Backport of: 458ba5a
Fixes: https://issues.redhat.com/browse/RHEL-61667
Does this PR introduce a user-facing change?