[v5.2-rhel] Add --health-max-log-count, --health-max-log-size, --health-log-destination flags #24216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
kind/api-change
Honny1
changed the title
openshift-ci
bot
added
release-note
and removed
do-not-merge/release-note-label-needed
Honny1
force-pushed
the
dev/jrodak/healthcheck-log
branch
from
be250e5
to
2f2a6ed
Compare
These flags can affect the output of the HealtCheck log. Currently, when a container is configured with HealthCheck, the output from the HealthCheck command is only logged to the container status file, which is accessible via `podman inspect`. It is also limited to the last five executions and the first 500 characters per execution. This makes debugging past problems very difficult, since the only information available about the failure of the HealthCheck command is the generic `healthcheck service failed` record. - The `--health-log-destination` flag sets the destination of the HealthCheck log. - `none`: (default behavior) `HealthCheckResults` are stored in overlay containers. (For example: `$runroot/healthcheck.log`) - `directory`: creates a log file named `<container-ID>-healthcheck.log` with JSON `HealthCheckResults` in the specified directory. - `events_logger`: The log will be written with logging mechanism set by events_loggeri. It also saves the log to a default directory, for performance on a system with a large number of logs. - The `--health-max-log-count` flag sets the maximum number of attempts in the HealthCheck log file. - A value of `0` indicates an infinite number of attempts in the log file. - The default value is `5` attempts in the log file. - The `--health-max-log-size` flag sets the maximum length of the log stored. - A value of `0` indicates an infinite log length. - The default value is `500` log characters. Add --health-max-log-count flag Signed-off-by: Jan Rodák <[email protected]> Add --health-max-log-size flag Signed-off-by: Jan Rodák <[email protected]> Add --health-log-destination flag Signed-off-by: Jan Rodák <[email protected]> (cherry picked from commit de856da) Signed-off-by: Jan Rodák <[email protected]>
|
AFAIK this requires proper backport Jira cards especially as this will also be in RHEL 9.5, as per Tom comment there this should only be in 5.3 and nerwer and I See no backport requests |
Honny1
force-pushed
the
dev/jrodak/healthcheck-log
branch
from
2f2a6ed
to
9975083
Compare
|
cc: @jnovy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags can affect the output of the HealtCheck log. Currently, when a container is configured with HealthCheck, the output from the HealthCheck command is only logged to the container status file, which is accessible via
podman inspect. It is also limited to the last five executions and the first 500 characters per execution.This makes debugging past problems very difficult, since the only information available about the failure of the HealthCheck command is the generic
healthcheck service failedrecord.The
--health-log-destinationflag sets the destination of the HealthCheck log.none: (default behavior)HealthCheckResultsare stored in overlay containers. (For example:$runroot/healthcheck.log)directory: creates a log file named<container-ID>-healthcheck.logwith JSONHealthCheckResultsin the specified directory.events_logger: The log will be written with logging mechanism set by events_loggeri. It also saves the log to a default directory, for performance on a system with a large number of logs.The
--health-max-log-countflag sets the maximum number of attempts in the HealthCheck log file.0indicates an infinite number of attempts in the log file.5attempts in the log file.The
--health-max-log-sizeflag sets the maximum length of the log stored.0indicates an infinite log length.500log characters.Add --health-max-log-count flag
Add --health-max-log-size flag
Add --health-log-destination flag
(cherry picked from commit de856da)
Fixes: https://issues.redhat.com/browse/RHEL-24623 (backport)
Does this PR introduce a user-facing change?