If podman or docker is available and we are not in a container #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
container-check
branch
from
22ab23b
to
6b22eb6
Compare
rhatdan
reviewed
Jul 28, 2024
ramalama
Outdated
| def select_container_manager(): | ||
| if available("podman"): | ||
| return "podman" | ||
| elif available("docker"): |
There was a problem hiding this comment.
Pushing with this change
We should re-exec this script inside a llama.cpp container (incomplete in this commit), truth is these AI runtime evironment are complex to set up by say installing a few packages, etc. The often require a certain version of mesa, llama.cpp, kernel drivers, ROCm, the list goes on and on depending on hardware. Although if one does want to run outside a container and or say they are running on macOS we should support that. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
container-check
branch
from
6b22eb6
to
4175613
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should re-exec this script inside a llama.cpp container (incomplete
in this commit), truth is these AI runtime evironment are complex to
set up by say installing a few packages, etc. The often require a
certain version of mesa, llama.cpp, kernel drivers, ROCm, the list goes
on and on depending on hardware. Although if one does want
to run outside a container and or say they are running on macOS we
should support that.