Add comments

cyfitech · Jun 8, 2022 · f6ae91a · f6ae91a
1 parent 147bb55
commit f6ae91a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/scripts/codebase_utils.sh b/scripts/codebase_utils.sh
@@ -13,6 +13,7 @@ export CRIS_CODE_DIRS="$(sed 's/^[[:space:]]*//' <<< "
 " | grep '[^[:space:]]')"
 
 function bazel_common_all () {
-    echo "$CR_CCACHE_CC_DIR:$PATH"
+    # Need to set PATH instead of CC because Bazel does not
+    # like '/'s in the CC value.
     PATH="$CR_CCACHE_CC_DIR:$PATH" bazel "$@" '//...'
 }
diff --git a/scripts/toolchain.sh b/scripts/toolchain.sh
@@ -17,6 +17,8 @@ if which ccache >/dev/null 2>&1 && ([ -d 'run' ] && [ -w 'run' ] || [ -w '.' ]);
     export CR_CCACHE_CC_DIR="$( realpath -e "run/toolchain")"
 
     for compiler in $CC $CXX; do
+        # Bazel may dereference the ccache symlink, so we use wrapper scripts instead.
+        # See https://github.com/bazelbuild/rules_cc/issues/130
         cat << EOF > "$CR_CCACHE_CC_DIR/$compiler"
 #!/bin/bash
 $(which ccache) $(which $compiler) \$@