Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Validate method invocation with extraneous headers #1355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WhitWaldo
Copy link
Contributor

Description

Added a unit test that verifies that if the developer creates an HttpMessageRequest via CreateInvokeMethodRequest on the DaprClient then appends additional headers to it, that these headers will be present on the intercepted HTTP request sent to the test client and not stripped away.

Also, fixed a spelling typo in a related class.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

This will not close #1352 but it just augments our existing unit test suite to close a gap.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • [N/A] Extended the documentation

@WhitWaldo WhitWaldo requested review from a team as code owners October 7, 2024 15:56
@WhitWaldo WhitWaldo self-assigned this Oct 7, 2024
@WhitWaldo WhitWaldo changed the title Validate method invocation with extraneous headers Test: Validate method invocation with extraneous headers Oct 7, 2024
@WhitWaldo WhitWaldo added this to the v1.15 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass Authorization header
1 participant