Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dapr-to-app communication when apps are behind a firewall #350

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ItalyPaleAle
Copy link
Contributor

This changes in the Go SDK are to support dapr/dapr#5731

1. Fixed SDK not compiling and tests failing
2. Increased minimum Go version to 1.18
3. Removed `github.com/pkg/errors` and `go.uber.org/atomic` - replaced with the standard library instead (the old packages have been added to the "depguard" linter)
4. Upgraded all dependencies
5. Upgraded golangci-lint to support Go 1.18+

Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Looks like the newer methods were added in Go 1.19 only

Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #350 (14a1b7d) into main (c537799) will decrease coverage by 3.73%.
The diff coverage is 3.03%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   69.41%   65.68%   -3.74%     
==========================================
  Files          30       31       +1     
  Lines        2253     2381     +128     
==========================================
  Hits         1564     1564              
- Misses        597      725     +128     
  Partials       92       92              
Impacted Files Coverage Δ
client/client.go 73.63% <ø> (ø)
service/grpc/callback_channel.go 0.00% <0.00%> (ø)
service/grpc/service.go 58.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant