Add support for HTTPS and H2C app protocols #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 69.17% 68.07% -1.11%
==========================================
Files 34 34
Lines 2735 2800 +65
==========================================
+ Hits 1892 1906 +14
- Misses 734 784 +50
- Partials 109 110 +1
☔ View full report in Codecov by Sentry. |
|
wait for related PRs merged. |
Which PR? The runtime features are merged |
|
validation isn't passing. |
|
Can you re-trigger it please? It's been a while since it ran |
|
Doesn't seem to be a way to re-trigger.. i'll reopen. |
…tocol Signed-off-by: ItalyPaleAle <[email protected]>
|
Uhm I don't understand what's causing the tests to fail. Everything is working fine, but the failure is here: Which is trying to kill a process and it fails, after having already stopped Dapr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to create a
servicethat uses HTTPS (incl. HTTP/2) or H2C (HTTP/2 Cleartext). Using HTTP/2 should offer significant performance improvements, for example due to support for multiplexing.http.NewServiceWithOptionswhich allows creating a service with options, including configuring the protocol explicitly ("https", "http", "h2c") and passing TLS certificatesAPP_PROTOCOL(see Inject APP_PROTOCOL in app containers dapr#6512 and Add APP_PROTOCOL env var for app cli#1318) is present, uses that to detect HTTPS or H2C usage