Adds new NewClientWithAddressContextNoEnvTimeout func

[JoshVanL]

As an app developer I do not want to have a default of 5 seconds timeout for connecting to daprd, and don't wish to use environment variables to configure this value. Instead, I would like to solely rely on the context I pass to the client New func.

Adds new NewClientWithAddressContextNoEnvTimeout func to create clientwhich ignores the DAPR_CLIENT_TIMEOUT_SECONDS env var.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4afb831) 70.00% compared to head (9e6b273) 70.04%.
Report is 22 commits behind head on main.

❗ Current head 9e6b273 differs from pull request most recent head 54abb81. Consider uploading reports for the commit 54abb81 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   70.00%   70.04%   +0.04%     
==========================================
  Files          33       33              
  Lines        2667     2671       +4     
==========================================
+ Hits         1867     1871       +4     
  Misses        698      698              
  Partials      102      102              

Files	Coverage Δ
client/client.go	70.73% <100.00%> (+0.98%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[artursouza]

We have an approved proposal that let's users configure the timeout via env variable. The name has changed, to become a standard across SDKs. Can this env variable be kept and change the default to be "no timeout" instead of 5s?

[artursouza]

Another options is to have the env var override the timeout for the context (if possible).

[JoshVanL]

I'd be happy to have the default to be no timeout if we don't consider that a breaking change.

[artursouza]

It is a breaking change. Yaron would need to accept that as a maintainer here. I am not.

…

On Wed, Aug 16, 2023 at 3:31 PM Josh van Leeuwen ***@***.***> wrote: I'd be happy to have the default to be no timeout if we don't consider that a breaking change. — Reply to this email directly, view it on GitHub <#437 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA77CT33CYL5O5FBKHYUZ3XVVC2RANCNFSM6AAAAAA3TE7Q5E> . You are receiving this because you commented.Message ID: ***@***.***>

[yaron2]

I have knowledge of Go-SDK users that rely on the default 5s timeout for various reasons, so I recommend to not change the default.

[daixiang0]

ping @JoshVanL