Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: allow clip to have int min or max when x is floating-point #811

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat!: allow clip to have int min or max when x is floating-point #811

wants to merge 5 commits into from

Commits on Jun 4, 2024

  1. Allow clip to have int min or max when x is floating-point 

    This is for consistency with operators, which allow combining an int with an
array that has a floating-point data type.

See the discussion at data-apis#807.
    @asmeurer
    asmeurer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    87d35df View commit details
    Browse the repository at this point in the history

  2. Fix a typo in the clip specification

    @asmeurer
    asmeurer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1109f3c View commit details
    Browse the repository at this point in the history

  3. Move clip change to the draft specification

    @asmeurer
    asmeurer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a2a6e0e View commit details
    Browse the repository at this point in the history

  4. Make it clear in clip() that min and max also broadcast together 

    This was somewhat implicit, but it should be clearer now that if all three
arguments are arrays that there is a three-way broadcast.
    @asmeurer
    asmeurer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    74c7f6d View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Clarify that a statement should only apply to scalars

    @asmeurer
    asmeurer committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    75cba91 View commit details
    Browse the repository at this point in the history