Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: thymeleaf (original, plain, original-wordmark, plain-wordmark) #1705

Merged
merged 12 commits into from
May 6, 2024

Conversation

ruubytes
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1657

Link to prove your SVG is correct and up-to-date.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but a plain or line icon is needed since thymeleaf-original.svg can not be used as a font, due to multiple paths and fill colors.

If you want to make a line icon, you can follow this guide: #1306 (comment)

Regardless if you choose plain or line, make sure it meets our SVG Standards.

If you want more info on the different SVG versions we use (e.g.) original, plain, line), you can read our SVG Versions wiki page.

@ruubytes
Copy link
Contributor Author

aye aye captain

@ruubytes ruubytes requested a review from Snailedlt March 17, 2023 15:18
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 17, 2023
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in "devicon.json" for "thymeleaf" entry: 
- missing key: 'font' in 'versions'.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

'font'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

1 similar comment
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

'font'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast. Looks like "font" is the only thing missing

devicon.json Show resolved Hide resolved
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@ruubytes
Copy link
Contributor Author

It didn't stop at the svgo-action, but the git auto commit action, what happened?

@ruubytes ruubytes changed the title new icon: thymeleaf (original) new icon: thymeleaf (original, plain) Mar 17, 2023
@Snailedlt
Copy link
Collaborator

@ruubytes Yeah, it's a known issue with the workflow -> #1715. Hopefully we can get around to fixing it soon, until the, you can safely ignore the Optimize Icons workflow entirely

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 20, 2023
@ruubytes ruubytes requested a review from Snailedlt March 21, 2023 15:30
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 21, 2023
@lunatic-fox lunatic-fox removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 23, 2023
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 23, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox previously approved these changes Mar 23, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a wordmark version for this logo (found it in their downloads page). It'd be great if you could add those as well. 🙂
The other icons look great by the way. Thanks! 🚀

@Snailedlt
Copy link
Collaborator

Here's all the official svg logos: https://github.com/thymeleaf/thymeleaf-org/blob/main/artwork/thymeleaf%202016/thymeleaf.svg

@lunatic-fox lunatic-fox added the stale For PRs that haven't had any activity for a while and old issues label Jun 1, 2023
@lunatic-fox lunatic-fox changed the title new icon: thymeleaf (original, plain) new icon: thymeleaf (original, plain, original-wordmark, plain-wordmark) Nov 5, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that everything is ok right now. ✔️
Thank you by this contribution! 🚀
image
image

@lunatic-fox lunatic-fox removed the stale For PRs that haven't had any activity for a while and old issues label Nov 5, 2023
@canaleal canaleal dismissed stale reviews from Snailedlt and Panquesito7 May 5, 2024 23:43

Issue resolved.

Copy link
Contributor

github-actions bot commented May 5, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit e3fcfa8 into devicons:develop May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants