-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: pug (original, plain, line) #2174
base: develop
Are you sure you want to change the base?
Conversation
First PR into here but hopefully have met all the required points. |
Ok, Ive optimised the original icon and included the suggested plain and original from @Snailedlt . How is it looking now @canaleal - let me know if I need to optimise anything else |
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Anything further needed on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some really small things, other than that looks good to me
Fix code block style
Co-authored-by: Patrik Wehrli <[email protected]>
Co-authored-by: Patrik Wehrli <[email protected]>
Co-authored-by: Patrik Wehrli <[email protected]>
Suggestions re newlines resolved, thanks @weh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far!
Almost done!
develop
branch.devicon.json
file at the correct alphabetic position as seen here**This PR closes #567 **
Link to prove your SVG is correct and up-to-date.
(https://github.com/pugjs/pug-logo/blob/master/SVG/pug-final-logo-_-colour-128.svg)