Update docs and change column order in Expiring Roles (#140)

discord · Sep 13, 2024 · 5bfcf3b · 5bfcf3b
1 parent ddbed73
commit 5bfcf3b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/pages/Home.tsx b/src/pages/Home.tsx
@@ -43,6 +43,8 @@ const guide: Record<string, Record<string, string>> = {
       "Every user, group, and role has a corresponding audit page, which shows the access history for the entity. It can be viewed by clicking the clock-arrow icon next to the user/role/group name on the entity's page. Roles additionally have a 'Role audit' page that can be viewed by clicking the icon below the clock-arrow icon on a role page (it's similar to a Celtic knot). It displays the role's membership and ownership history.",
     'Tags and Constraints':
       "Tags can be used to label groups and apps (for their app groups) and, optionally, to apply constraints. These constraints include setting an ownership or membership time limit, requiring a reason for access, and disabling owners from adding themselves as members of a group. To view tags, click the 'Tags' button at the top of the 'Groups' or 'Apps' pages.",
+    'Auto-approvals and other plugins':
+      'Access uses the Python pluggy framework to allow for additional functionality to be added to the system. Some examples of this include adding a notification plugin to send emails, SMS, etc. when access requests are made and resolved and adding a conditional access plugin to automatically approve or deny requests if they match certain conditions. For more information and examples of plugins, see the Access README at https://github.com/discord/access?tab=readme-ov-file#plugins.',
     'Learn more about Access':
       'Access is open-sourced under the Apache 2.0 license. View the source code at https://github.com/discord/access and check out our blog post that talks about the development process at dis.gd/access-blog.',
   },

diff --git a/src/pages/roles/BulkRenewal.tsx b/src/pages/roles/BulkRenewal.tsx
@@ -165,8 +165,8 @@ function BulkRenewalDialog(props: BulkRenewalDialogProps) {
   });
 
   const columns: GridColDef[] = [
-    {field: 'groupName', headerName: 'Group Name', flex: 1},
     {field: 'roleName', headerName: 'Role Name', flex: 1},
+    {field: 'groupName', headerName: 'Group Name', flex: 1},
     {field: 'groupType', headerName: 'Group Type', flex: 1},
     {field: 'memberOrOwner', headerName: 'Member or Owner', flex: 1},
     {field: 'started', headerName: 'Started', flex: 1},

diff --git a/src/pages/roles/Expiring.tsx b/src/pages/roles/Expiring.tsx
@@ -280,6 +280,7 @@ export default function ExpiringRoless() {
               </TableCell>
             </TableRow>
             <TableRow>
+              <TableCell>Role Name</TableCell>
               <TableCell>
                 <TableSortLabel
                   active={orderBy === 'moniker'}
@@ -288,7 +289,6 @@ export default function ExpiringRoless() {
                   Group Name
                 </TableSortLabel>
               </TableCell>
-              <TableCell>Role Name</TableCell>
               <TableCell>Group Type</TableCell>
               <TableCell>Member or Owner</TableCell>
               <TableCell>
@@ -320,34 +320,34 @@ export default function ExpiringRoless() {
                 <TableCell>
                   {(row.group?.deleted_at ?? null) != null ? (
                     <Link
-                      to={`/groups/${row.group?.id ?? ''}`}
+                      to={`/roles/${row.role_group?.id ?? ''}`}
                       sx={{textDecoration: 'line-through', color: 'inherit'}}
                       component={RouterLink}>
-                      {row.group?.name ?? ''}
+                      {row.role_group?.name ?? ''}
                     </Link>
                   ) : (
                     <Link
-                      to={`/groups/${row.group?.name ?? ''}`}
+                      to={`/roles/${row.role_group?.name ?? ''}`}
                       sx={{textDecoration: 'none', color: 'inherit'}}
                       component={RouterLink}>
-                      {row.group?.name ?? ''}
+                      {row.role_group?.name ?? ''}
                     </Link>
                   )}
                 </TableCell>
                 <TableCell>
                   {(row.group?.deleted_at ?? null) != null ? (
                     <Link
-                      to={`/roles/${row.role_group?.id ?? ''}`}
+                      to={`/groups/${row.group?.id ?? ''}`}
                       sx={{textDecoration: 'line-through', color: 'inherit'}}
                       component={RouterLink}>
-                      {row.role_group?.name ?? ''}
+                      {row.group?.name ?? ''}
                     </Link>
                   ) : (
                     <Link
-                      to={`/roles/${row.role_group?.name ?? ''}`}
+                      to={`/groups/${row.group?.name ?? ''}`}
                       sx={{textDecoration: 'none', color: 'inherit'}}
                       component={RouterLink}>
-                      {row.role_group?.name ?? ''}
+                      {row.group?.name ?? ''}
                     </Link>
                   )}
                 </TableCell>