Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: support for certificates for domains with zones in different Azure resource groups #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myhau
Copy link

@myhau myhau commented Oct 29, 2020

Current state

Currently, it is not possible to generate a single certificate for two domains (from two different Azure DNS zones) in two different resource groups, because of how --dns-azure-resource-group option works.

Example on how DNS zones might be organized in Azure:

domain1.com zone in group1 resource group
domain2.com zone in group2 resource group

My proposal

Accept multiple resource groups (comma separated) for --dns-azure-resource-group. During verification, find resource group for a particular zone when creating / deleting TXT record.

Example usage after the change:

certbot certonly \
 -d '*.domain1.com' \
 -d '*.domain2.com' \
 -a dns-azure \
 --dns-azure-credentials credentials.json \
 --dns-azure-resource-group group1,group2

This is a minimal working version. If (from the perspective of an end user) this change is ok, I will refactor the code and add tests / documentation if needed.

@myhau
Copy link
Author

myhau commented Nov 3, 2020

@dlapiduz what is your opinion ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant