command: add tests for container kill, commit, and pause #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5506 +/- ##
==========================================
+ Coverage 60.26% 60.59% +0.32%
==========================================
Files 345 345
Lines 23448 23448
==========================================
+ Hits 14132 14209 +77
+ Misses 8341 8263 -78
- Partials 975 976 +1 |
This commit adds tests for the commands docker kill, docker commit, and docker pause. Also, it creates the mock methods of the docker client ContainerCommit and ContainerPause so they can be used in the tests. For docker kill, it covers the cases that: - the command runs successfully - the client returns an error For docker commit, it covers the cases that: - the command runs successfully - the client returns an error For docker pause, it covers the cases that: - the command runs successfully - the client returns an error Signed-off-by: Stavros Panakakis <[email protected]>
Stavrospanakakis
force-pushed
the
cli-container-testing
branch
from
96b8e6f
to
442c386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This commit adds tests for the commands
docker kill,docker commit, anddocker pause. Also, it creates the mock methods of the docker clientContainerCommitandContainerPauseso they can be used in the tests.For
docker kill, it covers the cases that:For
docker commit, it covers the cases that:For
docker pause, it covers the cases that:- How I did it
I read all the test cases developed in
cli/command/containerdirectory and did the same forkill.go,commit.goandpause.gousing afakeClientand mocking the clientContainerKill,ContainerCommitandContainerPausemethods.- How to verify it
Run:
make test- Description for the changelog