-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a language specific guide for Bun #20936
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d6bc8e4
to
7fee82a
Compare
5004525
to
e4246ad
Compare
Ready for review (Apologies for above mess) Wow, there was a lot of conflict and logical change. I think docs have changed how it resolves the path plus folder structure. |
Co-authored-by: David Karlsson <[email protected]>
Co-authored-by: David Karlsson <[email protected]>
Co-authored-by: David Karlsson <[email protected]>
Thanks for the review, @dvdksn. Updated the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests are failing, could you check your links?
Also, I would like us to add a bit more detail to this guide. Other than the sample project, it doesn't contain any information or examples specific to Docker+Bun. Is there something more we can say about developing with Docker and Bun that might be useful to add here? For example, if there are differences between how the official node
image and the oven/bun
work, or if there's anything to keep in mind w.r.t. cache mounts, etc.
Hey, @dvdksn, The links are fine I double-checked. Could you point out which link is creating the issue? Also, I checked the error in Workflow it seems something different
I was thinking of adding more content to this guide in another PR and was thinking of this one to go live and iterate over it. But, I will add more details to this PR itself. Thnak you. |
Thanks @Pradumnasaraf. Let's add the details to this PR. |
The actual error is a bit obstructed in the logs;
|
Hey, #22 2.371 ERROR [en] REF_NOT_FOUND: Ref "/manuals/compose/file-watch.md" from page "/guides/language/bun/develop": page not found I checked the page is there and the same link is added to other guides as well. I am not sure why it's giving an error. It's working fine as well when running locally. Plus, I have updated the guide, let me know if you have any more feedback. Thanks! |
Description
Add language specfic guide for Bun
Related issues or tickets
Closes #20796
Reviews