DSPHLE/AXWii: fix wiimote audio in multiple games #13102
+194
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes Wii Remote audio in those games. Tested on Passthrough and Emulated Wii Remotes. |
iwubcode
reviewed
Oct 5, 2024
Tilka
force-pushed
the
ax3
branch
3 times, most recently
from
6202bf0
to
c6c8c9c
Compare
Three bugs specific to older Wii games: - The size difference between high-pass and biquad filter was not accounted for, causing wiimote related fields to be corrupted. - Wiimote sample buffer pointers were advanced by 32 samples per millisecond instead of 6 samples. Usually hidden by the first bug. - PB updates on Wii were being byte-swapped twice, but I've not actually found any Wii games that make use of PB updates. This fixes wiimote audio in at least the following games: - Excite Truck - Ice Age 2: The Meltdown - Kororinpa: Marble Mania - Rapala Tournament Fishing - Shrek the Third - Super Monkey Ball: Banana Blitz - Tiger Woods PGA Tour 07 - WarioWare: Smooth Moves (issue 11725) - Wing Island
Tilka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three bugs specific to older Wii games:
This fixes wiimote audio in at least the following games: