-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemd-battery-check): introducing the systemd-battery-check module #2419
base: master
Are you sure you want to change the base?
feat(systemd-battery-check): introducing the systemd-battery-check module #2419
Conversation
…dule Introducing the systemd-battery-check module.
@aafeijoo-suse how have you tested this dracut module ? From a quick look it seems this module requires quite a lot of things to work
|
~30s to compile the main branch.
I haven't added
My hw from the emergency shell of any standard SUSE distro:
Yes, we may specify here the required kernel drivers, but the |
Thanks for these details. I also think not requiring plymouth is OK, but just wondering how and when would the user see why the system did not boot (so that the user can then take an action), if the system simply just shuts down on low battery. We had similar related discussion at #2332 (review) I think it is ok to shutdown the device even if the user is not properly informed, but we should continue to discuss how can we inform the user.
We can optimize the module later with follow-up PRs. One idea could be that in hostonly mode it might make sense to check for /sys/class/power_supply/ like it is done in the bluetooth module to optimize initramfs size and boot time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
See https://github.com/systemd/systemd/blob/main/man/systemd-battery-check.service.xml
Checklist