Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve maintenance of test containers #2423

Closed
wants to merge 2 commits into from

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Jul 9, 2023

Install AUR helper (paru) into Arch test container and improve maintenance of test containers.

Pulls in #2427 as one of the commits in this PR.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #2422 #2433

@github-actions github-actions bot added the test Issues related to testing label Jul 9, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Henrik66 .

Can you please also add pcsclite package ?

Can you see if you can find a way not to install mkinitcpio (the default initramfs provider on arch) ? There is a possibly solution used in the Debian container to avoid having initramfs-tools installed.

test/container/Dockerfile-Arch Outdated Show resolved Hide resolved
test/container/Dockerfile-Arch Outdated Show resolved Hide resolved
test/container/Dockerfile-Arch Outdated Show resolved Hide resolved
@Henrik66
Copy link
Contributor Author

Henrik66 commented Jul 9, 2023

Can you see if you can find a way not to install mkinitcpio (the default initramfs provider on arch) ? There is a possibly solution used in the Debian container to avoid having initramfs-tools installed.

I found out that assume-installed option can do this.

Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Henrik66
Copy link
Contributor Author

Start working on #2433 .

Pulling in #2427 as this PR would help with #2433 .

Marking in draft for now as I will likely need help with this PR.

@Henrik66 Henrik66 marked this pull request as draft July 15, 2023 20:22
@Henrik66 Henrik66 force-pushed the archcontainer branch 7 times, most recently from 3447d5d to edee523 Compare July 15, 2023 21:15
@github-actions github-actions bot added the github Issues related to .github label Jul 15, 2023
@Henrik66 Henrik66 force-pushed the archcontainer branch 12 times, most recently from 782f746 to bc8dd71 Compare July 16, 2023 01:05
@Henrik66 Henrik66 force-pushed the archcontainer branch 7 times, most recently from ebbe839 to 7164fb0 Compare July 16, 2023 05:21
@Henrik66 Henrik66 changed the title ci: install AUR helper into Arch test container ci: improve maintenance of test containers Jul 16, 2023
@Henrik66 Henrik66 marked this pull request as ready for review July 16, 2023 05:25
@LaszloGombos
Copy link
Collaborator

LaszloGombos commented Jul 16, 2023

I think this helps reason about the differences of test containers, which should help reason about about test results.

Let's use this opportunity to make a few more changes:

Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully this helps with maintenance - and at least now we have a list of common packages installed in the containers.

Install more packages to enable more testing on Arch.
@bdrung
Copy link
Contributor

bdrung commented Aug 19, 2023

The test code is harder to read and harder to copy-paste after this change.

The list would be easier to maintain if the entries would be grouped by topic. Example question: Why is btrfs-progs not installed on openSUSE? There are many packages that just have different names. Having those in one place would help, but I have no idea how to codify that in a readable way.

opensuse-tumbleweed: ShellCheck, others: shellcheck
fedora|opensuse-tumbleweed: kernel, debian|ubuntu: linux-image-generic

@LaszloGombos
Copy link
Collaborator

LaszloGombos commented Aug 19, 2023

The test code is harder to read and harder to copy-paste after this change.

This is subjective and I hope to avoid copy-paste.

The list would be easier to maintain if the entries would be grouped by topic. Example question: Why is btrfs-progs not installed on openSUSE?

This is a question I also had, but please recognize that this question probably would not even be on the table if we continue just copy-paste. This is one value of somehow harmonizing the containers.

There are many packages that just have different names.

Not that many, but some for sure.

Having those in one place would help, but I have no idea how to codify that in a readable way.

I hope @aafeijoo-suse would also chime in here on what is his preference.

In reality sometimes we need to investigate why a new dracut module or a new test-case fails only on one distribution. Having packages in one place would help.

opensuse-tumbleweed: ShellCheck, others: shellcheck
fedora|opensuse-tumbleweed: kernel, debian|ubuntu: linux-image-generic

I think @Henrik66 could work on making this syntax work if this is what it takes to reach a consensus.

Some documentation also references package names - https://github.com/dracutdevs/dracut/blob/master/docs/README.generic . We should either remove these or replace them with some syntax that considers several distributions.

@bdrung
Copy link
Contributor

bdrung commented Aug 19, 2023

Some documentation also references package names - https://github.com/dracutdevs/dracut/blob/master/docs/README.generic . We should either remove these or replace them with some syntax that considers several distributions.

Is this list referring to projects or package names?

Also "Generic initramfs'es are huge (usually over 10 megs in size uncompressed)" is a little outdated. The generic initramfs is more around 100 MB and uncompressed in hundreds of megabytes.

@pvalena
Copy link
Contributor

pvalena commented Oct 5, 2023

LGTM, although I've not verified the package lists.

@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@Henrik66 Henrik66 force-pushed the archcontainer branch 4 times, most recently from 1f8ad12 to 2158862 Compare November 25, 2023 19:37
Consolidate list of package generation into test-packages.sh tool.

Add jq to all test containers.

Remove g++, less and quilt from Debian test container.

Add iscsiuio to dpkg based distributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve arch test container
5 participants