CWE-434: Unrestricted Upload of File with Dangerous Type. Polyglot fi… #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Sep 30, 2024
…le could lead to remote code execution dustin10#1468
garak
requested changes
Oct 1, 2024
| $basename = \substr(\pathinfo($originalName, \PATHINFO_FILENAME), 0, 240); | ||
| $basename = \strtolower($this->transliterator->transliterate($basename)); | ||
| $slug = \sprintf('%s.%s', $basename, $extension); | ||
| $slug = $extension ? \sprintf('%s.%s', $basename, $extension) : $basename; |
There was a problem hiding this comment.
Implicit casting here too (and in other similar statements)
There was a problem hiding this comment.
There is implicit casting in Base64Namer from the master branch, do you want me to change it here too ?
VichUploaderBundle/src/Naming/Base64Namer.php
Lines 44 to 46 in 8056cd5
There was a problem hiding this comment.
avoiding adding new ones is enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests were broken after my changes. I tried to update the tests based on the following Symfony Component
https://github.com/symfony/symfony/blob/10ac2449d459117ca7318c3773e613b90b9a08e3/src/Symfony/Component/HttpFoundation/File/File.php#L53-L59
https://github.com/symfony/symfony/blob/10ac2449d459117ca7318c3773e613b90b9a08e3/src/Symfony/Component/Mime/MimeTypes.php#L142
Issue: #1468