Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary tryCatch() statements targeting insight::download_model() #746

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Remove unnecessary tryCatch() statements targeting insight::download_model() #746

merged 4 commits into from
Jul 11, 2024

Conversation

strengejacke
Copy link
Member

Fixes #732

@strengejacke
Copy link
Member Author

Oh, I haven't looked in other tests yet. Or was only this file affected?

@strengejacke
Copy link
Member Author

And we could switch to httr2, or not?

@strengejacke strengejacke merged commit db8ab03 into main Jul 11, 2024
21 checks passed
@strengejacke strengejacke deleted the strengejacke/issue732 branch July 11, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary tryCatch() statements targeting insight::download_model()
2 participants
@strengejacke @IndrajeetPatil