Don't round raw data input.

eclipse · Aug 31, 2024 · 7ec136b · 7ec136b
1 parent 3c4726e
commit 7ec136b
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 37 deletions.
diff --git a/...ipse/chemclipse/msd/converter/supplier/mmass/internal/io/MassSpectrumReaderVersion22.java b/...ipse/chemclipse/msd/converter/supplier/mmass/internal/io/MassSpectrumReaderVersion22.java
@@ -34,7 +34,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mmass.converter.model.IVendorMassSpectra;
 import org.eclipse.chemclipse.msd.converter.supplier.mmass.converter.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mmass.converter.model.VendorMassSpectra;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IMassSpectra;
 import org.eclipse.chemclipse.msd.model.core.IVendorMassSpectrum;
 import org.eclipse.chemclipse.msd.model.core.IVendorStandaloneMassSpectrum;
@@ -145,9 +144,7 @@ private void readSpectrum(Element element, IVendorMassSpectrum massSpectrum) thr
 			}
 		}
 		for(int i = 0; i < points; i++) {
-			float intensity = intensities[i];
-			double mz = AbstractIon.getIon(mzs[i]);
-			IVendorIon ion = new VendorIon(mz, intensity);
+			IVendorIon ion = new VendorIon(mzs[i], intensities[i]);
 			massSpectrum.addIon(ion);
 		}
 	}

diff --git a/...se/chemclipse/msd/converter/supplier/mzdata/internal/io/MassSpectrumReaderVersion105.java b/...se/chemclipse/msd/converter/supplier/mzdata/internal/io/MassSpectrumReaderVersion105.java
@@ -31,7 +31,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzdata.model.IVendorMassSpectra;
 import org.eclipse.chemclipse.msd.converter.supplier.mzdata.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzdata.model.VendorMassSpectra;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IMassSpectra;
 import org.eclipse.chemclipse.msd.model.core.IVendorStandaloneMassSpectrum;
 import org.eclipse.chemclipse.msd.model.implementation.VendorStandaloneMassSpectrum;
@@ -98,9 +97,7 @@ public IMassSpectra read(File file, IProgressMonitor monitor) throws IOException
 			double[] intensities = ReaderVersion105.parseData(spectrum.getIntenArrayBinary().getData());
 			int length = Math.min(mzs.length, intensities.length);
 			for(int i = 0; i < length; i++) {
-				double mz = AbstractIon.getIon(mzs[i]);
-				float intensity = (float)intensities[i];
-				IVendorIon ion = new VendorIon(mz, intensity);
+				IVendorIon ion = new VendorIon(mzs[i], (float)intensities[i]);
 				massSpectrum.addIon(ion);
 			}
 		} catch(SAXException e) {

diff --git a/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzml/internal/converter/XmlReader.java b/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzml/internal/converter/XmlReader.java
@@ -15,7 +15,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzml.converter.model.IVendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzml.converter.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzml.converter.model.VendorScan;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IIon;
 import org.eclipse.chemclipse.msd.model.core.IVendorMassSpectrum;
 
@@ -43,10 +42,8 @@ public static void addIons(double[] intensities, double[] mzs, IVendorMassSpectr
 
 		int ions = Math.min(mzs.length, intensities.length);
 		for(int i = 0; i < ions; i++) {
-			double intensity = intensities[i];
-			double mz = AbstractIon.getIon(mzs[i]);
-			if(intensity >= Float.MIN_VALUE && intensity <= Float.MAX_VALUE) {
-				IVendorIon ion = new VendorIon(mz, (float)intensity);
+			if(intensities[i] >= Float.MIN_VALUE && intensities[i] <= Float.MAX_VALUE) {
+				IVendorIon ion = new VendorIon(mzs[i], (float)intensities[i]);
 				massSpectrum.addIon(ion);
 			}
 		}

diff --git a/...ipse/chemclipse/msd/converter/supplier/mzxml/internal/io/MassSpectrumReaderVersion20.java b/...ipse/chemclipse/msd/converter/supplier/mzxml/internal/io/MassSpectrumReaderVersion20.java
@@ -37,7 +37,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.IVendorMassSpectra;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorMassSpectra;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IMassSpectra;
 import org.eclipse.chemclipse.msd.model.core.IVendorStandaloneMassSpectrum;
 import org.eclipse.chemclipse.msd.model.implementation.VendorMassSpectrum;
@@ -117,9 +116,7 @@ public IMassSpectra read(File file, IProgressMonitor monitor) throws IOException
 					/*
 					 * Get m/z and intensity (m/z-int)
 					 */
-					double mz = AbstractIon.getIon(values[peakIndex]);
-					float intensity = (float)values[peakIndex + 1];
-					IVendorIon ion = new VendorIon(mz, intensity);
+					IVendorIon ion = new VendorIon(values[peakIndex], (float)values[peakIndex + 1]);
 					massSpectrum.addIon(ion);
 				}
 				monitor.worked(1);

diff --git a/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion21.java b/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion21.java
@@ -39,7 +39,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorChromatogram;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorScan;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IChromatogramMSD;
 import org.eclipse.chemclipse.msd.model.core.Polarity;
 import org.eclipse.chemclipse.support.history.EditInformation;
@@ -57,7 +56,6 @@ public class ReaderVersion21 extends AbstractReaderVersion implements IChromatog
 	public static final String VERSION = "mzXML_2.1";
 	//
 	private static final Logger logger = Logger.getLogger(ReaderVersion21.class);
-	private static final int ION_PRECISION = 6;
 
 	@Override
 	public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOException {
@@ -145,9 +143,7 @@ public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOExcep
 					/*
 					 * Get m/z and intensity (m/z-int)
 					 */
-					double mz = AbstractIon.getIon(values[peakIndex], ION_PRECISION);
-					float intensity = (float)values[peakIndex + 1];
-					IVendorIon ion = new VendorIon(mz, intensity);
+					IVendorIon ion = new VendorIon(values[peakIndex], (float)values[peakIndex + 1]);
 					massSpectrum.addIon(ion);
 				}
 				chromatogram.addScan(massSpectrum);

diff --git a/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion22.java b/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion22.java
@@ -39,7 +39,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorChromatogram;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorScan;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IChromatogramMSD;
 import org.eclipse.chemclipse.msd.model.core.Polarity;
 import org.eclipse.chemclipse.support.history.EditInformation;
@@ -57,7 +56,6 @@ public class ReaderVersion22 extends AbstractReaderVersion implements IChromatog
 	public static final String VERSION = "mzXML_2.2";
 	//
 	private static final Logger logger = Logger.getLogger(ReaderVersion22.class);
-	private static final int ION_PRECISION = 6;
 
 	@Override
 	public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOException {
@@ -145,9 +143,7 @@ public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOExcep
 					/*
 					 * Get m/z and intensity (m/z-int)
 					 */
-					double mz = AbstractIon.getIon(values[peakIndex], ION_PRECISION);
-					float intensity = (float)values[peakIndex + 1];
-					IVendorIon ion = new VendorIon(mz, intensity);
+					IVendorIon ion = new VendorIon(values[peakIndex], (float)values[peakIndex + 1]);
 					massSpectrum.addIon(ion);
 				}
 				chromatogram.addScan(massSpectrum);

diff --git a/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion30.java b/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion30.java
@@ -41,7 +41,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorChromatogram;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorScan;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IChromatogramMSD;
 import org.eclipse.chemclipse.msd.model.core.Polarity;
 import org.eclipse.chemclipse.support.history.EditInformation;
@@ -59,7 +58,6 @@ public class ReaderVersion30 extends AbstractReaderVersion implements IChromatog
 	public static final String VERSION = "mzXML_3.0";
 	//
 	private static final Logger logger = Logger.getLogger(ReaderVersion30.class);
-	private static final int ION_PRECISION = 6;
 
 	@Override
 	public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOException {
@@ -156,9 +154,7 @@ public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOExcep
 						/*
 						 * Get m/z and intensity (m/z-int)
 						 */
-						double mz = AbstractIon.getIon(values[peakIndex], ION_PRECISION);
-						float intensity = (float)values[peakIndex + 1];
-						IVendorIon ion = new VendorIon(mz, intensity);
+						IVendorIon ion = new VendorIon(values[peakIndex], (float)values[peakIndex + 1]);
 						massSpectrum.addIon(ion);
 					}
 				}

diff --git a/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion31.java b/.../src/org/eclipse/chemclipse/msd/converter/supplier/mzxml/internal/io/ReaderVersion31.java
@@ -41,7 +41,6 @@
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorChromatogram;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorIon;
 import org.eclipse.chemclipse.msd.converter.supplier.mzxml.model.VendorScan;
-import org.eclipse.chemclipse.msd.model.core.AbstractIon;
 import org.eclipse.chemclipse.msd.model.core.IChromatogramMSD;
 import org.eclipse.chemclipse.msd.model.core.Polarity;
 import org.eclipse.chemclipse.support.history.EditInformation;
@@ -59,7 +58,6 @@ public class ReaderVersion31 extends AbstractReaderVersion implements IChromatog
 	public static final String VERSION = "mzXML_3.1";
 	//
 	private static final Logger logger = Logger.getLogger(ReaderVersion31.class);
-	private static final int ION_PRECISION = 6;
 
 	@Override
 	public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOException {
@@ -156,9 +154,7 @@ public IChromatogramMSD read(File file, IProgressMonitor monitor) throws IOExcep
 						/*
 						 * Get m/z and intensity (m/z-int)
 						 */
-						double mz = AbstractIon.getIon(values[peakIndex], ION_PRECISION);
-						float intensity = (float)values[peakIndex + 1];
-						IVendorIon ion = new VendorIon(mz, intensity);
+						IVendorIon ion = new VendorIon(values[peakIndex], (float)values[peakIndex + 1]);
 						massSpectrum.addIon(ion);
 					}
 				}