WIP: support aria role for native classes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
changed the title
|
WIP cause #44 needs to be merged before. Will rebase afterwards. Feel free to start the actual review before. |
jelhan
added a commit
to jelhan/ember-bootstrap
that referenced
this pull request
Jan 23, 2020
This is the result of running the tagless-ember-components-codemod against Ember Bootstrap. The following open pull request have been merged in before: - Support native classes: ember-codemods/tagless-ember-components-codemod#44 - Support component with event handlers: ember-codemods/tagless-ember-components-codemod#52 - Support aria role for native classes: ember-codemods/tagless-ember-components-codemod#56 Steps: mv addon/templates/components/common addon/templates/components/base npx jelhan/tagless-ember-components-codemod#merged-native-class-support mv addon/templates/components/base addon/templates/components/common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
ariaRoleon classic components was implemented in #51. This pull request extends the support to native classes as well.This is based on top of #44, which should be merged before.