docs: add clarifications to readme #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
commented
Jun 29, 2024
benmccann
commented
- show how to set it up without the recommended configs. I only wanted to setup a single rule and had a very difficult time
- show the new config format first and the legacy format after
- don't duplicate legend symbols
scagood
requested changes
Jun 29, 2024
Comment on lines
+82
to
+84
| "plugins": { | ||
| "n": node | ||
| }, |
There was a problem hiding this comment.
Im not sure this'll work in the legacy version?
There was a problem hiding this comment.
I don't know. I only have the new version to test on. We can remove this section
Co-authored-by: Sebastian Good <[email protected]>
aladdin-add
reviewed
Jul 1, 2024
Comment on lines
+82
to
+84
| "plugins": { | ||
| "n": node | ||
| }, |
There was a problem hiding this comment.
in eslintrc mode, it should be:
Suggested change
| "plugins": { | |
| "n": node | |
| }, | |
| "plugins": ["n"], |
|
can you look at the ci failing - seems markdown-lint was not happy somehow: https://github.com/eslint-community/eslint-plugin-n/actions/runs/9725270531/job/26842381101?pr=303 |
|
it has been landed in dbdfa8e. thanks for contributing!:) |
1 similar comment
|
it has been landed in dbdfa8e. thanks for contributing!:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.