Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reversed root->leaf to leaf->root #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sabotagebeats
Copy link

@sabotagebeats sabotagebeats commented Mar 10, 2022

What was wrong?

reversed root->leaf to leaf->root in trie/smt.py

How was it fixed?

removed reversed()

Cute Animal Picture

https://i.natgeofe.com/k/c022030e-f1aa-4ab3-ad56-fdcdd4a1d08b/125-animals-tiger_4x3.jpg

fixes #129

@sabotagebeats
Copy link
Author

Please let me know if there's anything other I need to do. I may also need to fix tests.

@kclowes
Copy link
Contributor

kclowes commented Apr 29, 2022

Thanks for the PR @sabotagebeats! Sorry it got lost in the shuffle. Without digging into this too closely, it looks like removing reverse is a breaking change. But it looks like the tests pass if that part is removed. To be merged, tests need to be passing, and ideally a test case would be added for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smt.exists(item) doesn't work if default node value is set
2 participants