Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cytoolz hard dependency and CI fixes #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

6ug
Copy link
Contributor

@6ug 6ug commented Oct 19, 2018

What was wrong?

Fixed #70 with 5cd74f8

  • Remove cytoolz from the direct dependencies.
  • Update the eth-utils requirement to be >=1.3.0,<2
  • Update all imports that come from cytoolz to instead come from eth_utils.toolz

Fixes #69 with a236489

  • Add the eth-typing>=2.0.0,<3 library as a dependency.
  • Add a new command to the flake8 environment in the tox.ini file that runs
  • Update the setup.py to expose data to other libraries
  • Add all missing type hints.

Cute Animal Picture

Cute animal picture

@6ug 6ug changed the title Removed cytoolz hard dependency Removed cytoolz hard dependency and CI fixes Oct 19, 2018
Fixes ethereum#67
* Updated classifiers in setup.py
* Added python3.7 to tox.ini
* Added python3.7 run(s) to .travis.yml

TODO: Fix any issues or failures that are exposed.
@pipermerriam
Copy link
Member

@6ug I believe you can remove the .travis.yml file as it is no longer needed.

@pipermerriam
Copy link
Member

@6ug looks like you can lower the eth-utils to >=1.2.2. 1.3.0 is still in beta.

@pipermerriam
Copy link
Member

some sort of dependency failure that I'll dig into on Monday if it isn't resolved by then.

I'm also good with dropping support for rlp<1 and requiring the newer version of the library.

@carver
Copy link
Contributor

carver commented Oct 19, 2018

At least one issue is that mypy was never added as a dependency in setup.py

@6ug
Copy link
Contributor Author

6ug commented Oct 20, 2018

I'm also good with dropping support for rlp<1 and requiring the newer version of the library.

@pipermerriam are you talking about dropping rlp<1 and using newer versions for rlp<1 ? or second sentence was about libraries in general?

do you know exact supportive versions? I tried with rlp0: rlp>=1.0.3,<2 and rlp1: rlp>=1,<2, it did not worked for me.

@pipermerriam
Copy link
Member

@6ug

We currently support two major version ranges of pyrlp. The 0.x line and the 1.x line. I'm proposing that we drop support for rlp<1 which would allow removal of the rlp0/rlp1 deliniation in the tox.ini and ci runs, and only test against rlp>=1,<2.

pacrob pushed a commit to pacrob/py-trie that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants