Code Quality: WinAppSdk 1.6 #16156

yaira2 · 2024-09-08T15:57:22Z

Updated WinAppSdk to 1.6
Removed workaround for auto hide taskbar

f1amy · 2024-09-09T08:17:58Z

Will this utilize new native AOT compilation?

0x5bfa · 2024-09-09T08:30:45Z

Not yet, we have still some blocker (Vanara package). I've been removing it.

yaira2 · 2024-09-09T14:17:00Z

Will this utilize new native AOT compilation?

Aside from what @0x5bfa mentioned, the AOT support in WinAppSdk 1.6 is a bit rough and we might have to wait for future versions of WinAppSdk before we can enable it.

yaira2 · 2024-09-11T15:51:00Z

The two issues we're currently having with this PR are

The accessibility tests (fyi @marcelwgn)
Shell previews cause Files to crash

hez2010 · 2024-09-12T00:10:33Z

You need to add the latest CsWinRT reference to all projects using WinRT APIs, they have a source generator for this.
You can use <WindowsSdkPackageVersion>10.0.22621.42</WindowsSdkPackageVersion>.
Some classes need to be marked as partial after you update CsWinRT.

yaira2 · 2024-09-12T00:53:53Z

You need to add the latest CsWinRT reference to all projects using WinRT APIs, they have a source generator for this.

The last time we tried updating it caused a bunch of crashes, but it could be that updating WinAppSdk will solve this issue.

Some classes need to be marked as partial after you update CsWinRT.

How do you know which ones?

hez2010 · 2024-09-12T01:27:40Z

How do you know which ones?

The analyzer bundled with WinRT will tell you and yield a compilation error if there's anything missing.

hez2010 · 2024-09-12T08:27:16Z

I will check later today.

yaira2 · 2024-09-29T15:12:29Z

@hez2010 @marcelwgn any ideas regarding the testing project?

0x5bfa

Btw PreviewHandler.cs looks great.
The CI log is expired, rerunning may help others look into.

hez2010 · 2024-09-29T16:59:42Z

@hez2010 @marcelwgn any ideas regarding the testing project?

Resolved in #16276.

src/Files.App.Server/Files.App.Server.csproj

This reverts commit d59412d.

Co-authored-by: 0x5BFA <[email protected]>

yaira2 · 2024-09-30T02:44:35Z

This seems to have the same issues we encountered the last time we updated to .NET 8.0.8. I was hoping the latest version of WinAppSdk would resolve the issues, but unfortunately it hasn't.

yaira2 · 2024-09-30T14:34:02Z

Here are some stacktraces

System.Runtime.InteropServices.COMException: null
  ?, in void AppLifecycleHelper.HandleAppUnhandledException(Exception ex, bool showToastNotification)
  ?, in int UnhandledExceptionEventHandler.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr e)
  ?, in void IFrameMethods.GoBack(IObjectReference _obj)
  ?, in void ModernShellPage.Back_Click()
  ?, in Task NavigateBackAction.ExecuteAsync(object parameter)
  ?, in async void ActionCommand.Execute(object parameter)
  ?, in void AsyncMethodBuilderCore.Start<TStateMachine>(ref TStateMachine stateMachine)
  ?, in void ActionCommand.Execute(object parameter)
  ?, in int Vftbl.Do_Abi_Execute_3(IntPtr thisPtr, IntPtr parameter)
  ?, in void IApplicationStaticsMethods.Start(IObjectReference _obj, ApplicationInitializationCallback callback)
  ?, in void Program.Main()

System.Runtime.InteropServices.COMException: null
  ?, in void AppLifecycleHelper.HandleAppUnhandledException(Exception ex, bool showToastNotification)
  ?, in int UnhandledExceptionEventHandler.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr e)
  ?, in bool IFrameMethods.Navigate(IObjectReference _obj, Type sourcePageType, object parameter, NavigationTransitionInfo infoOverride)
  ?, in void ModernShellPage.NavigateToPath(string navigationPath, Type sourcePageType, NavigationArguments navArgs)
  ?, in async Task NavigationHelpers.OpenPathAsync(bool forceOpenInNewTab, bool openFolderInNewTabSetting, string path, string text, IShellPage associatedInstance, IEnumerable<string> selectItems)
  ?, in void AsyncMethodBuilderCore.Start<TStateMachine>(ref TStateMachine stateMachine)
  ?, in Task NavigationHelpers.OpenPathAsync(bool forceOpenInNewTab, bool openFolderInNewTabSetting, string path, string text, IShellPage associatedInstance, IEnumerable<string> selectItems)
  ?, in async Task<FilesystemResult> NavigationHelpers.OpenDirectory(string path, IShellPage associatedInstance, IEnumerable<string> selectItems, ShellLinkItem shortcutInfo, bool forceOpenInNewTab)
  ?, in void AsyncStateMachineBox<TStateMachine>.ExecutionContextCallback(object s)
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread) x 2
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in void AsyncTaskMethodBuilder<TResult>.SetExistingTaskResult(Task<TResult> task, TResult result)
  ?, in async Task<FilesystemResult> FilesystemTasks.OnSuccess<T>(Task<FilesystemResult<T>> wrapped, Action<T> func)
  ?, in void AsyncStateMachineBox<TStateMachine>.ExecutionContextCallback(object s)
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread) x 2
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in void AsyncTaskMethodBuilder<TResult>.SetExistingTaskResult(Task<TResult> task, TResult result)
  ?, in async Task<FilesystemResult<StorageFolderWithPath>> ShellViewModel.GetFolderWithPathFromPathAsync(string value, CancellationToken cancellationToken)
  ?, in void AsyncStateMachineBox<TStateMachine>.ExecutionContextCallback(object s)
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread) x 2
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in void AsyncTaskMethodBuilder<TResult>.SetResult(TResult result)
  ?, in async Task<FilesystemResult<T>> FilesystemTasks.Wrap<T>(Func<Task<T>> wrapped)
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread)
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in async Task<StorageFolderWithPath> StorageFileExtensions.DangerousGetFolderWithPathFromPathAsync(string value, StorageFolderWithPath rootFolder, StorageFolderWithPath parentFolder)
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread)
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in void AsyncInfoToTaskBridge<TResult, TProgress>.Complete(IAsyncInfo asyncInfo, Func<IAsyncInfo, TResult> getResultsFunction, AsyncStatus asyncStatus)
  ?, in void TaskToAsyncInfoAdapter<TCompletedHandler, TProgressHandler, TResult, TProgressInfo>.TaskCompleted()
  ?, in bool ThreadPoolTaskScheduler.TryExecuteTaskInline(Task task, bool taskWasPreviouslyQueued)
  ?, in void TaskContinuation.InlineIfPossibleOrElseQueue(Task task, bool needsProtection)
  ?, in void ContinueWithTaskContinuation.Run(Task completedTask, bool canInlineContinuationTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in async IAsyncOperation<BaseStorageFolder> BaseStorageFolder.GetFolderFromPathAsync(string path)+(?) => { }
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread)
  ?, in void AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in void AsyncInfoToTaskBridge<TResult, TProgress>.Complete(IAsyncInfo asyncInfo, Func<IAsyncInfo, TResult> getResultsFunction, AsyncStatus asyncStatus)
  ?, in void TaskToAsyncInfoAdapter<TCompletedHandler, TProgressHandler, TResult, TProgressInfo>.TaskCompleted()
  ?, in bool ThreadPoolTaskScheduler.TryExecuteTaskInline(Task task, bool taskWasPreviouslyQueued)
  ?, in void TaskContinuation.InlineIfPossibleOrElseQueue(Task task, bool needsProtection)
  ?, in void ContinueWithTaskContinuation.Run(Task completedTask, bool canInlineContinuationTask)
  ?, in void Task.RunContinuations(object continuationObject)
  ?, in async IAsyncOperation<BaseStorageFolder> SystemStorageFolder.FromPathAsync(string path)+(?) => { }
  ?, in void AsyncStateMachineBox<TStateMachine>.MoveNext(Thread threadPoolThread)
  ?, in void DispatcherQueueSynchronizationContext.Post(SendOrPostCallback d, object state)+() => { }
  ?, in int DispatcherQueueHandler.Do_Abi_Invoke(IntPtr thisPtr)
  ?, in void IApplicationStaticsMethods.Start(IObjectReference _obj, ApplicationInitializationCallback callback)
  ?, in void Program.Main()

Just to clarify, this issue happens in .NET 8.0.7 as well, but it's a lot more frequent in 8.0.8.

yaira2 · 2024-09-30T14:46:18Z

This might be relevant dotnet/maui#22790

…6156)

0x5bfa · 2024-10-02T10:20:01Z

src/Files.App (Package)/Files.Package.wapproj

@@ -107,8 +107,8 @@
    </ProjectReference>
  </ItemGroup>
  <ItemGroup>
-    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240627000" IncludeAssets="build" />
-    <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" IncludeAssets="build" />
+    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" IncludeAssets="build" />


Suggested change

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" IncludeAssets="build" />

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240923002" IncludeAssets="build" />

0x5bfa · 2024-10-02T10:21:44Z

src/Files.App.Controls/Files.App.Controls.csproj

-        <PackageReference Include="CommunityToolkit.WinUI.UI" Version="7.1.2" />
-        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240627000" />
-        <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" />
+        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" />


Suggested change

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" />

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240923002" />

0x5bfa · 2024-10-02T10:23:49Z

src/Files.App/Files.App.csproj

-        <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.8" />
-        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240627000" />
+        <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.10" />
+        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" />


Suggested change

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" />

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240923002" />

0x5bfa · 2024-10-02T10:25:29Z

src/Files.App/Files.App.csproj

-        <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.8" />
-        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240627000" />
+        <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.10" />
+        <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" />
        <PackageReference Include="Microsoft.Graphics.Win2D" Version="1.2.0" />
        <PackageReference Include="CommunityToolkit.WinUI.UI.Behaviors" Version="7.1.2" />
        <PackageReference Include="CommunityToolkit.WinUI.UI.Controls" Version="7.1.2" />
        <PackageReference Include="TagLibSharp" Version="2.3.0" />
        <PackageReference Include="Tulpep.ActiveDirectoryObjectPicker" Version="3.0.11" />
        <PackageReference Include="WinUIEx" Version="2.3.4" />


Suggested change

<PackageReference Include="WinUIEx" Version="2.3.4" />

<PackageReference Include="WinUIEx" Version="2.4.2" />

yaira2 · 2024-10-06T14:39:01Z

We might have to wait for .NET 9 to see if this is resolved.

yaira2 marked this pull request as draft September 8, 2024 16:24

yaira2 force-pushed the ya/wasdk branch from cff141f to e1ff641 Compare September 11, 2024 15:44

yaira2 force-pushed the ya/wasdk branch 2 times, most recently from 3a188ed to e7025f3 Compare September 12, 2024 16:29

yaira2 marked this pull request as ready for review September 12, 2024 20:22

yaira2 force-pushed the ya/wasdk branch from 7788536 to fb25e20 Compare September 16, 2024 21:26

Lamparter mentioned this pull request Sep 22, 2024

Infra: .NET Native AOT 0x5bfa/FluentHub#515

Closed

4 tasks

0x5bfa mentioned this pull request Sep 24, 2024

Code Quality: Removed Vanara from shell preview handler #15911

Draft

This was referenced Sep 25, 2024

Bug: Files crashes with memory error when browsing files with file preview enabled #16254

Open

Constantly Closing #16184

Open

0x5bfa reviewed Sep 29, 2024

View reviewed changes

yaira2 commented Sep 29, 2024

View reviewed changes

src/Files.App.Server/Files.App.Server.csproj Show resolved Hide resolved

yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 29, 2024

yaira2 and others added 7 commits September 29, 2024 16:58

WASDK

715be3f

WebView2

efd3005

WindowsSdkPackageVersion

248a73d

Update CsWinRT

71df918

Define Microsoft.UI

c725e8d

Fix wasdk 1.6 (#16181)

e32677a

Removed auto hide taskbar workaround

6629a2e

yaira2 and others added 4 commits September 29, 2024 16:59

Appium.WebDriver

6fc76dd

Revert "Appium.WebDriver"

24d867a

This reverts commit d59412d.

Code Quality: Fixed solution configurations in ya/wasdk (#16190)

94c0d57

WASDK 1.6: Fix build and tests (#16276)

e97360e

Co-authored-by: 0x5BFA <[email protected]>

yaira2 force-pushed the ya/wasdk branch from 730cf5b to e97360e Compare September 29, 2024 20:59

Build: v3.7.9

7ffa652

yaira2 temporarily deployed to Deployments September 29, 2024 21:58 — with GitHub Actions Inactive

yaira2 pushed a commit that referenced this pull request Oct 1, 2024

Fix: Fixed an issue when navigating the sidebar using the tab key (#1…

239f4bc

…6156)

0x5bfa reviewed Oct 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code Quality: WinAppSdk 1.6 #16156

Code Quality: WinAppSdk 1.6 #16156

yaira2 commented Sep 8, 2024 •

edited

Loading

f1amy commented Sep 9, 2024

0x5bfa commented Sep 9, 2024

yaira2 commented Sep 9, 2024 •

edited

Loading

yaira2 commented Sep 11, 2024 •

edited

Loading

hez2010 commented Sep 12, 2024

yaira2 commented Sep 12, 2024

hez2010 commented Sep 12, 2024

hez2010 commented Sep 12, 2024

yaira2 commented Sep 29, 2024

0x5bfa left a comment

hez2010 commented Sep 29, 2024

yaira2 commented Sep 30, 2024

yaira2 commented Sep 30, 2024 •

edited

Loading

yaira2 commented Sep 30, 2024

0x5bfa Oct 2, 2024

0x5bfa Oct 2, 2024

0x5bfa Oct 2, 2024

0x5bfa Oct 2, 2024

yaira2 commented Oct 6, 2024

	<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" IncludeAssets="build" />
	<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240923002" IncludeAssets="build" />

	<PackageReference Include="WinUIEx" Version="2.3.4" />
	<PackageReference Include="WinUIEx" Version="2.4.2" />

Code Quality: WinAppSdk 1.6 #16156

Are you sure you want to change the base?

Code Quality: WinAppSdk 1.6 #16156

Conversation

yaira2 commented Sep 8, 2024 • edited Loading

f1amy commented Sep 9, 2024

0x5bfa commented Sep 9, 2024

yaira2 commented Sep 9, 2024 • edited Loading

yaira2 commented Sep 11, 2024 • edited Loading

hez2010 commented Sep 12, 2024

yaira2 commented Sep 12, 2024

hez2010 commented Sep 12, 2024

hez2010 commented Sep 12, 2024

yaira2 commented Sep 29, 2024

0x5bfa left a comment

Choose a reason for hiding this comment

hez2010 commented Sep 29, 2024

yaira2 commented Sep 30, 2024

yaira2 commented Sep 30, 2024 • edited Loading

yaira2 commented Sep 30, 2024

0x5bfa Oct 2, 2024

Choose a reason for hiding this comment

0x5bfa Oct 2, 2024

Choose a reason for hiding this comment

0x5bfa Oct 2, 2024

Choose a reason for hiding this comment

0x5bfa Oct 2, 2024

Choose a reason for hiding this comment

yaira2 commented Oct 6, 2024

yaira2 commented Sep 8, 2024 •

edited

Loading

yaira2 commented Sep 9, 2024 •

edited

Loading

yaira2 commented Sep 11, 2024 •

edited

Loading

yaira2 commented Sep 30, 2024 •

edited

Loading