Fix segfault due to invalid iterator #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Jul 14, 2023
Yes! Will do, noticed that we currently do not test the Update: Adapted tests to use the unsubscribe operation. Trigger a segfault without 20d9d2e |
achim-k
added a commit
to foxglove/ws-protocol
that referenced
this pull request
Jul 14, 2023
achim-k
added a commit
to foxglove/ws-protocol
that referenced
this pull request
Jul 17, 2023
### Public-Facing Changes C++ implementation: Fix segfault due to invalid iterator ### Description See foxglove/ros-foxglove-bridge#251
pezy
pushed a commit
to pezy/ws-protocol
that referenced
this pull request
Jul 27, 2023
### Public-Facing Changes C++ implementation: Fix segfault due to invalid iterator ### Description See foxglove/ros-foxglove-bridge#251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Fix segfault due to invalid iterator
Description
Fixes a segfault caused by using an invalid iterator as argument to
std::unordered_map<...>::erase. This regression was introduced in #250.