Communicate double / double array parameters with type info, explicitly cast when set from integer #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Communicate double / double array parameters with type info, explicitly cast when set from integer
Description
Implements foxglove/ws-protocol#519
PARAMETER_DOUBLE
("type": "float64"
) or anPARAMETER_ARRAY
ofPARAMETER_DOUBLE
("type": "float64_array"
)setParameters
request from the client, the server checks if the parametertype
field is present and attempts to cast the parameter value (or values in case it's an array) to adouble
in case the type isfloat64
/float64_array
. This is mainly relevant for ROS2 as setting a double parameter to an integer will raise an exception. In ROS1, one can change the parameter type on the fly