Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'NoneType' object has no attribute 'has_serial_no' (backport #43514) #43574

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2024

  File "apps/erpnext/erpnext/controllers/stock_controller.py", line 248, in make_bundle_for_sales_purchase_return
    self.make_bundle_for_non_rejected_qty(table_name)
  File "apps/erpnext/erpnext/controllers/stock_controller.py", line 303, in make_bundle_for_non_rejected_qty
    field, reference_ids = self.get_reference_ids(table_name)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/erpnext/erpnext/controllers/stock_controller.py", line 340, in get_reference_ids
    if not self.is_serial_batch_item(row.item_code):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/utils/caching.py", line 59, in wrapper
    return_val = func(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^
  File "apps/erpnext/erpnext/controllers/stock_controller.py", line 362, in is_serial_batch_item
    if item_details.has_serial_no or item_details.has_batch_no:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'has_serial_no'
```<hr>This is an automatic backport of pull request #43514 done by [Mergify](https://mergify.com).

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Oct 8, 2024
@rohitwaghchaure rohitwaghchaure merged commit 60508a9 into version-15-hotfix Oct 9, 2024
12 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-15-hotfix/pr-43514 branch October 9, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant